Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/buildkite] #1785 namespace defined templates with chart name#1979

Merged
mgoodness merged 1 commit intohelm:masterfrom
kevinschumacher:feature/1785-namespace-helpers-buildkite
Sep 10, 2017
Merged

[stable/buildkite] #1785 namespace defined templates with chart name#1979
mgoodness merged 1 commit intohelm:masterfrom
kevinschumacher:feature/1785-namespace-helpers-buildkite

Conversation

@kevinschumacher
Copy link
Contributor

@kevinschumacher kevinschumacher commented Sep 4, 2017

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 4, 2017

Hi @kevinschumacher. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 4, 2017
@kevinschumacher kevinschumacher mentioned this pull request Sep 4, 2017
Closed
@mgoodness mgoodness self-assigned this Sep 10, 2017
@mgoodness
Copy link
Contributor

mgoodness commented Sep 10, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 10, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 10, 2017

@kevinschumacher: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-charts-e2e b324911 link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mgoodness
Copy link
Contributor

mgoodness commented Sep 10, 2017

Build failure expected; missing require values.

@mgoodness
Copy link
Contributor

mgoodness commented Sep 10, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2017
@mgoodness mgoodness merged commit a698d74 into helm:master Sep 10, 2017
@kevinschumacher kevinschumacher deleted the feature/1785-namespace-helpers-buildkite branch September 10, 2017 22:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@mgoodness mgoodness

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevinschumacher @k8s-ci-robot @mgoodness